Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include libicu-dev in the build #37

Open
fresheneesz opened this issue Oct 18, 2013 · 2 comments
Open

Include libicu-dev in the build #37

fresheneesz opened this issue Oct 18, 2013 · 2 comments

Comments

@fresheneesz
Copy link

npm install should be enough to install node-stringprep. The user shouldn't have to do a bunch of other crap to get this to install - thats the whole point of a package management system like npm.

I think you can probably just put an appropriate preinstall script in package.json that checks what kind of linux you have and runs the right stuff to install libicu.

@mcfiredrill
Copy link

Or it could at least check the version of libicu and abort if its too old.

@mcfiredrill
Copy link

Although it looks like it should here:
https://github.com/node-xmpp/node-stringprep/blob/master/wscript#L16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants