Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chaining multiple proxy results in rejected shares #62

Closed
MaxLap opened this issue Dec 29, 2017 · 2 comments
Closed

Chaining multiple proxy results in rejected shares #62

MaxLap opened this issue Dec 29, 2017 · 2 comments
Labels

Comments

@MaxLap
Copy link

MaxLap commented Dec 29, 2017

I am pretty sure it should be possible to chain multiple Stratum proxy one after the other. However, it doesn't work with this proxy. If I make my miner go through 2 of them, then every shares will be rejected by the 2nd proxy (the one closer to the pool) with the message: Invalid nonce; is miner not compatible with NiceHash?.

The cause is this chunk:

else if (!event->request.isCompatible(m_fixedByte)) {
event->reject(Error::InvalidNonce);
}

If I just comment out the reject call, then the miner's shares are accepted and I can see them on the pool's website. So I'm not sure exactly what this test is for, but it seems to block some uses cases that seem valid.

I was just curious about what a Stratum proxy does and thought this should work. This might not be much of an issue to anyone, but it might indicate a deeper issue.

@xmrig
Copy link
Owner

xmrig commented Dec 30, 2017

It not just stratum proxy, it’s nicehash proxy, it reduce connection count to pool. If you remove this check it undefined behavior, but chaining will work until you have less than 256 workers.
If you need chaining you sould use pure tcp proxy like haproxy.
Thank you.

@xmrig xmrig added the question label Dec 30, 2017
@xmrig
Copy link
Owner

xmrig commented Mar 1, 2018

Merge with #118

@xmrig xmrig closed this as completed Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants