Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contracts deployment script should allow to specify the environment #15

Open
fbac opened this issue Mar 10, 2025 · 2 comments
Open

Contracts deployment script should allow to specify the environment #15

fbac opened this issue Mar 10, 2025 · 2 comments
Assignees

Comments

@fbac
Copy link
Collaborator

fbac commented Mar 10, 2025

We'll be deploying contracts in multiple chains.
Currently, the folders inside config are separated by chain, but an environment (i.e testnet) can be composed by contracts in multiple chains.

Instead of the actual approach, modify forge scripts to allow for grouping or similar solutions:

environment
 |- chain1
 |   |- contractA.json
 |   |_ contractB.json
 |_ chain2
     |- contractC.json
     |_ contractD.json
@neekolas
Copy link
Collaborator

@fbac this is done, right?

@mkysel mkysel moved this to Todo in Decentralization Mar 11, 2025
@fbac
Copy link
Collaborator Author

fbac commented Mar 12, 2025

@fbac this is done, right?

Not yet. Right now we generate the config json files and group them based on the chainId they were deployed to. The first problem is that when deploying contracts for testnet-playground or testnet will override the other env, as they both share the same chainId.

The second problem is our deployments will be multichain so I'd want the deployer to specify the environment to deploy, and generate the config in its folder.

@mkysel mkysel transferred this issue from xmtp/xmtpd Mar 20, 2025
@fbac fbac self-assigned this Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants