Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xo.enable is only detected on config change and not on startup #139

Closed
easrng opened this issue Feb 5, 2024 · 3 comments
Closed

xo.enable is only detected on config change and not on startup #139

easrng opened this issue Feb 5, 2024 · 3 comments
Assignees
Labels

Comments

@easrng
Copy link

easrng commented Feb 5, 2024

I have a project that uses node and xo, with a subfolder that uses deno and deno's linter. When I open the subfolder, which has a vscode config like {"deno.enable": true, "xo.enable": false}, xo still reports errors. If I change it to "xo.enable": true and then back to "xo.enable": false, xo disables itself properly.

@spence-s
Copy link
Collaborator

spence-s commented Feb 5, 2024

I am not sure I understand the problem here entirely. Having nested vscode configurations isn't something I am really aware of. It's likely the best way to solve this issue is to ignore the subfolder you don't want to lint in the xo configuration or add a .eslintignore file.

see: https://github.com/xojs/xo?tab=readme-ov-file#ignores

Let me know if this will work for you.

@easrng
Copy link
Author

easrng commented Feb 5, 2024

No, I open the subfolder as a separate vscode workspace. I'm already ignoring the subfolder, which works fine when I have the main workspace open, but iirc not when I open the subfolder itself as a workspace.

@spence-s spence-s self-assigned this Feb 5, 2024
@spence-s spence-s added the bug label Feb 5, 2024
@spence-s
Copy link
Collaborator

Should be fixed as of v3.19 let me know if you have any more issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants