Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built-in support for TypeScript #373

Closed
sindresorhus opened this issue Jan 21, 2019 · 6 comments · Fixed by #426
Closed

Built-in support for TypeScript #373

sindresorhus opened this issue Jan 21, 2019 · 6 comments · Fixed by #426
Assignees
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@sindresorhus
Copy link
Member

sindresorhus commented Jan 21, 2019

Issuehunt badges

Now that the TypeScript project is officially committed to using and supporting ESLint, I would like to explore adding built-in support for TypeScript in XO. You can already use TypeScript with XO, but I would like to make it just work.

I have already updated the shareable TS config for the new plugin: xojs/eslint-config-xo-typescript@1161b41

XO will add TypeScript and the TypeScript ESLint plugin as a dependency.

We still need to discuss how it will exactly work. Can we manage to do it without any setting?

Note to self: Should lint foo.d.ts (TS definition files) in non-TS projects automatically.


This issue requires you to have extensive JS knowledge. It's not an easy issue. Only undertake it if you are confident you can handle it and you intend to see it through.


IssueHunt Summary

pvdlg pvdlg has been rewarded.

Backers (Total: $200.00)

Submitted pull Requests


Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@novemberborn
Copy link

You can apply those rules to *.ts, *.tsx files specifically. One caveat is that the parser warns pretty aggressively when your TypeScript version is newer. It's all still rather finicky.

@IssueHuntBot
Copy link

@IssueHunt has funded $200.00 to this issue.


@pedroapfilho
Copy link

How is the status of this issue? Anything we can do to help?

@pvdlg
Copy link
Contributor

pvdlg commented Feb 13, 2020

I'll start working on this issue soon. I need to experiment but I think I can make it work without an option.
Every .ts/.tsx would be linted with the xo config + the config from eslint-config-xo-typescript

@issuehunt-oss
Copy link

issuehunt-oss bot commented Feb 24, 2020

@sindresorhus has rewarded $180.00 to @pvdlg. See it on IssueHunt

  • 💰 Total deposit: $200.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $20.00

@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels Feb 24, 2020
@fregante
Copy link
Member

fregante commented Apr 8, 2020

🌮

XO is working great with TypeScript now!

I was able to drop a lot of config and workarounds for the parserOptions.project issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants