-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for vue3 #25
Comments
Great question. I have been wanting to do this but decided to wait until it's released. Having said that, when compiled it shouldn't make any difference, so Vue3's more for dev than anything. |
Hi. I'd love to use it in a project as all the other gmap plugins seems crappy. |
@thefoxie may have gotten side tracked. I'll find some time this weekend to scope it out. Been meaning to anyway. Thanks for the prompt @stereonom |
As an update, I have started work on this. I will publish a beta soon (~1 week) for comments and changes from anyone interested. |
@xon52 I wish I had the time. I've got 2 projects simultaneously and it's nuts (no time for anything). I will be glad if I'm able to help with something/anything, just mention me. |
All good @thefoxie, when I'm done I'll ping you for a code review and test. |
I was giving x5-gmaps a try using Vue3 when it appears I ran into a related issue. Uncaught TypeError: Class extends value undefined is not a constructor or null I haven't been able to work around it so wondering if this is part of the Vue3 issue? (Oh and this was just using the simple example in the readme.) |
@kbottner I just fixed a breaking issue but I think it's different to what you're describing. I will see if I can do a quick and dirty Vue3 port ASAP. I ran into some technical challenges in my first Vue 3 version and decided to fix up Vue 2 version first. |
Happy to give it a try when you have something ready. |
Hi, @xon52. Is this Vue3 version published on npm? |
@markpruett571 TBH this just fell behind and I was too busy to restart it. Might try pick it up again this weekend. |
Pretty self explanatory. I'll provide the PR. Do you want to split it to another repo, create monorepo or have branches like main containing vue3 code and vue2 branch containing vue2 code? Or main could have vue2 and next vue3 till the shift in npm vue package when vue will become vue3 by default.
The text was updated successfully, but these errors were encountered: