Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #63 #99

Merged
merged 2 commits into from
Jun 8, 2020
Merged

fixes #63 #99

merged 2 commits into from
Jun 8, 2020

Conversation

trullock
Copy link
Owner

@trullock trullock commented Jun 6, 2020

I'm not entirely sure if the outputted javascript is exactly "right", but given we're parsing mangled input markup I'm not sure what to do.

  1. This fixes the infinite loop, which even if the outputted JS is "wrong" at least it doesnt crash/hang
  2. What is NUglify's stance on handling bad input syntax - do we care, as long as errors are reported? Do we not output anything at all? Do we not output the mangled statement, and resume at the next good bit? This PR outputs something from the mangled input

@trullock trullock merged commit a13f95f into trullock:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant