Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Same content with different line endings produce different HTML #534

Closed
yufeih opened this issue Mar 23, 2021 · 2 comments · Fixed by #560
Closed

Same content with different line endings produce different HTML #534

yufeih opened this issue Mar 23, 2021 · 2 comments · Fixed by #560
Labels
bug

Comments

@yufeih
Copy link
Contributor

yufeih commented Mar 23, 2021 •
edited
Loading

Starting from 0.24.0, line ending (\r\n or \n) affects output in certain cases:

Console.WriteLine(Markdown.ToHtml("a\\\nb"));      // <p>a<br />b</p>
Console.WriteLine(Markdown.ToHtml("a\\\r\nb"));    // <p>a\b</p>
Console.WriteLine(Markdown.ToHtml("a  \nb"));      // <p>a</br />b</p>
Console.WriteLine(Markdown.ToHtml("a  \r\nb"));    // <p>a  </br />b</p>

Related: dotnet/docfx#7219 dotnet/docfx#7424
@xoofx xoofx added the bug label Mar 23, 2021
@xoofx
Copy link
Owner

xoofx commented Mar 23, 2021

It is likely a regression from #481

@generateui could you have a look?

@generateui
Copy link

I'll take a look.

@yufeih yufeih mentioned this issue Jun 29, 2021
Merged
@xoofx xoofx closed this as completed in #560 Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix rendering diff between line endings yufeih/markdig
3 participants
@generateui @yufeih @xoofx