Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy support #90

Closed
rogerlz opened this issue Jan 31, 2018 · 2 comments
Closed

proxy support #90

rogerlz opened this issue Jan 31, 2018 · 2 comments

Comments

@rogerlz
Copy link

rogerlz commented Jan 31, 2018

Hi,

r10k supports proxy in the r10k.yaml (https://github.com/puppetlabs/r10k/blob/master/r10k.yaml.example)

It would be good to have that feature available for g10k. Any thoughts before I start coding a patch?

Thanks

@xorpaul
Copy link
Owner

xorpaul commented Jan 31, 2018

I really thought I mentioned proxy support in the readme or in the --help output.

Like curl, wget or git you can set the environment variables http_proxy and/or https_proxy for g10k

g10k/forge.go

Line 159 in 394c5f6

proxyURL, err := http.ProxyFromEnvironment(req)

https://golang.org/pkg/net/http/#ProxyFromEnvironment

I'll update the readme.

@rogerlz
Copy link
Author

rogerlz commented Feb 1, 2018

thank you. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants