sensors - allow a second BMX280 sensor #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add thermostat to the espurna_modules in progmem.h 2. Add thermostat to webui, gulp, html, js. 3. in general.h MQTT_USE_JSON returned to 0 by default and 1 if thermostat enabled.
# Conflicts: # code/espurna/config/webui.h # code/espurna/data/index.all.html.gz # code/espurna/data/index.light.html.gz # code/espurna/data/index.rfbridge.html.gz # code/espurna/data/index.rfm69.html.gz # code/espurna/data/index.sensor.html.gz # code/espurna/data/index.small.html.gz # code/espurna/espurna.ino # code/espurna/static/index.all.html.gz.h # code/espurna/static/index.light.html.gz.h # code/espurna/static/index.rfbridge.html.gz.h # code/espurna/static/index.rfm69.html.gz.h # code/espurna/static/index.sensor.html.gz.h # code/espurna/static/index.small.html.gz.h # code/espurna/web.ino # code/gulpfile.js # code/html/index.html
Mine was not working till I added BUTTON_SET_PULLUP | BUTTON_DEFAULT_HIGH
- wrapper NTPClient class to avoid inadvertently calling NTP::getTime() while setting things up - only call NTP::getTime() when in loop(), install async TimeLib sync provider and manually set TimeLib time - randomize sync and delay times
…resent its magnitude types; update sensor.ino to take advantage of this knowledge; sensors BMX280 and Dallas OneWire are updated with this knowledge; tested with BME280 and Dallas DS18B20 sensors
merging back from Xose
|
Don't know how to resolve the Codacy quality review, either BMX280_ADDRESS2 is defined or not, and the firmware builds either way. |
…io-intr Event sensor: do not detach existing interrupts
…ecimals Sensors can determine precision of their magnitudes
|
Hack-ish but it works, of course. You don't have to specify the individual addresses. Setting both to 0x00 will work since the auto-discover procedure will take care of the already used ones. Maybe it will be better to add a BMX280_NUMBER to specify the number of sensors connected (1 or 2). |
Add option to disable relay reporting to MQTT
Add thermostat module
Adding support for Generic GU10 bulb
update hardware.h GREEN_ESP8266RELAY button1 mode
…into mcspr-webui/switch-typo
|
OK I can re-work it, but... non-auto addressing is important. Order matters. If I have sensor 0x76 on the "incoming air" and sensor 0x77 on the "outgoing air" I don't ever want those mixed up. |
|
It will always load sensor at 0x76 first. But yes, if you want to be define the order yourself then you are right. |
…ses 0x76 and 0x77. Currently espurna only supports one of them. This change adds a second sensor object to deal with two sensors, if BMX280_NUMBER == 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to two BMX280 sensors are allowed on a single I2C bus, with addresses 0x76 and 0x77. Currently espurna only supports one of them.
This change adds a second sensor object to deal with two sensors, if BMX280_ADDRESS2 is defined.