Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BMX280Sensor #1690

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Update BMX280Sensor #1690

merged 2 commits into from
Apr 11, 2019

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Apr 10, 2019

resolves #1672

  • default to one sensor
  • dynamic number and address setting
  • do not return i2c-specific error for wrong values
    (unless it is some value returned by Wire.read() and not sensor?)

@mcspr
Default to one BMX280 sensor
24c4826
@mcspr
Update BMX280Sensor
0b73882 
- dynamic number and address setting
- do not return i2c-specific error for wrong values
@mcspr mcspr mentioned this pull request Apr 10, 2019
Closed
@mcspr
Copy link
Collaborator Author

mcspr commented Apr 10, 2019

And another thing - maybe address setting should use HEX format?
Maybe optional, with 0x prefix check

@xoseperez xoseperez merged commit f86a3c6 into xoseperez:dev Apr 11, 2019
@mcspr mcspr deleted the bmx280/update branch April 11, 2019 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BME280/BMP280 sensor shows 'Wrong ID' in values section.
2 participants
@mcspr @xoseperez