Xiaomi Desklamp Rotary Encoder Bugs

[fluffymadness]

There are some weird issues with my xiaomi desklamp
I upgraded to the latest nightly that is linked via github
and the rotary encoder behavior is completely broken
when i try to dim down in dims down a bit and is then full brightness again
same with color change
when i turn the wheel to the right it changes between yellow and white gradually
worked fine on older builds
newest tasmota with the xiaomi desklamp module has the same issue for me

(espurna-1.13.6-dev.nightly20191001+gitbd385f9f-xiaomi-smart-desk-lamp) broken
#1621 (comment) -> works fine

[mcspr]

Thanks for the report! I do see the issue here:

espurna/code/espurna/light.ino

Line 939 in bd385f9

lightBrightness(_light_brightness + steps * LIGHT_STEP);

When step is negative and brightness already approaches 0, lightBrightness function receives negative value. Due to signed / unsigned conversion, resulting brightness is converted from -1 to some value near 4294967295 and in the end into the 100% that you are seeing
I can't see any issues with the encoder handling, but will re-check in the morning and commit the fix.

[fluffymadness]

thanks for the quick reply. Another thing I've noticed, is it maybe possible to expose color temperature via mqtt ? The pregenerated homeassistant template from espurna only gives me brightness control.

light:
  - name: ESPURNA_83D22DF2
    state_topic: ESPURNA-83D22DF2/relay/0
    command_topic: ESPURNA-83D22DF2/relay/0/set
    payload_on: 1
    payload_off: 0
    availability_topic: ESPURNA-83D22DF2/status
    payload_available: 1
    payload_not_available: 0
    brightness_state_topic: ESPURNA-83D22DF2/brightness
    brightness_command_topic: ESPURNA-83D22DF2/brightness/set

[mcspr]

See if #1938 fixes this. I have a simple encoder setup to mimic xiaomi lamp and it seems to work in both button modes.

For color_temp topic to appear you need to enable both useWhite and useCCT in the settings

[fluffymadness]

Everything works fine now. Encoder behavior for changing color temperature and brightness and also setting this values via homeassistant. Thanks