Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed small aesthetic problem #2038

Merged
merged 2 commits into from
Dec 9, 2019
Merged

Fixed small aesthetic problem #2038

merged 2 commits into from
Dec 9, 2019

Conversation

foxman69
Copy link
Contributor

@foxman69 foxman69 commented Dec 2, 2019

The letter-spacing in the "Modes" label (LED tab) gets broken when on small display (see the photo below)

2019-12-02_211253

Fixed it by changing from pure-u-0 to pure-u-1

@mcspr
Copy link
Collaborator

mcspr commented Dec 4, 2019

Huh, c/p strikes again.

I kind of like legend more

--- a/code/html/index.html
+++ b/code/html/index.html
@@ -421,8 +421,9 @@

                             <fieldset>

+                                <legend class="module module-led">Modes</legend>
+
                                 <div class="pure-g module module-led">
-                                    <div class="pure-u-0 pure-u-lg-1-4">Modes</div>
                                     <div class="pure-u-1 pure-u-lg-3-4 hint">
                                         <li><strong>WiFi status</strong> will blink at 1Hz when trying to connect. If successfully connected it will briefly blink every 5 seconds if in STA mode or every second if in AP mode.</li>
                                         <li><strong>Follow switch</strong> will force the LED to follow the status of a given switch (you must define which switch to follow in the side field).</li>

@foxman69
Copy link
Contributor Author

foxman69 commented Dec 4, 2019

you are right, it does look better.
I have changed it to legend instead

@mcspr
Copy link
Collaborator

mcspr commented Dec 4, 2019

Thanks! I need to go through some maintanence commits first and will add this after those are done

@mcspr mcspr added this to the 1.14.1 milestone Dec 9, 2019
@mcspr mcspr merged commit 5cf687f into xoseperez:dev Dec 9, 2019
@foxman69 foxman69 deleted the dev7 branch June 9, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants