Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@irmishappy (sorry for the delay)
Resolves ... (TODO: find all related issues)
While this solves the energy conversion issues and we are finally seeing the real value, what I don't really like:
I have found some alternative systems:
https://github.com/nholthaus/units/
Which implement unit as strongly typed class that can be used to enforce our runtime checks at compile time. Non-trivial part is that I am not really sure what structure the code must use to implement strongly typed getters. We can do something like:
And we still need to check specific run-time property of the sensor to know what getter outputs correct data. We would get rid of conversion stuff though, it would magically do it all by itself.
(Note that I am not sure about the underlying type / value stuff and whether we can hit some limits there, units.h source is pretty cryptic :/)