Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BME680 fixes #2361

Merged
merged 3 commits into from
Sep 24, 2020
Merged

BME680 fixes #2361

merged 3 commits into from
Sep 24, 2020

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Sep 24, 2020

  • make sure we call run() before checking for errors, we will miss status update otherwise and lock the sensor class in the error state that it cannot recover from
  • set error flag only when either bsec or bme680 report an error. ensure we show any issues reported by the library via the debug log
    (as a theoretical TODO - add custom error messages through virtual method?)
  • minor fix to the sensor.h when using 1m,2m boards

@mcspr
sns/bme680: make sure we call run() before checking for errors
45a6b24
@mcspr
sns/bme680: rework logging
bf8802c 
Set error flag only when either bsec or bme680 report an error
Ensure we show any issues reported by the library
@mcspr
sns: fix D1-specific GPIO alias
48afc52
@mcspr mcspr merged commit c72ca3f into xoseperez:dev Sep 24, 2020
@mcspr mcspr deleted the sns/fixes branch September 24, 2020 04:47
@ruimarinho
Copy link
Contributor

Nice one @mcspr 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcspr @ruimarinho