Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial improvement in p:directory-list #555

Closed
ndw opened this issue Apr 23, 2024 · 1 comment · Fixed by #557
Closed

Editorial improvement in p:directory-list #555

ndw opened this issue Apr 23, 2024 · 1 comment · Fixed by #557
Labels
consensus reached

Comments

@ndw
Copy link
Collaborator

ndw commented Apr 23, 2024

In the discussion of include-filter, where its discussing matches and their relationship to descendants, it says:

They need to match, the regular expression, too.

That's either an incomplete sentence or just oddly punctuated, depending on how you read it.
@xatapult
Copy link
Contributor

Yeah, that's not correct sentence.

@ndw ndw mentioned this issue Apr 24, 2024
Merged
@ndw ndw closed this as completed in #557 Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
consensus reached
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve the description of include-file processing in p:directory-list ndw/steps
2 participants
@ndw @xatapult