Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unspecified p:error behavior #623

Closed
xatapult opened this issue Sep 5, 2024 · 2 comments · Fixed by #624
Closed

Unspecified p:error behavior #623

xatapult opened this issue Sep 5, 2024 · 2 comments · Fixed by #624
Labels
standard step library Issues for the standard step library

Comments

@xatapult
Copy link
Contributor

xatapult commented Sep 5, 2024

The p:error step has a source port with sequence="true". The spec leaves it unspecified what must happen when there are multiple documents on the source port. There are, I think, two options:

  1. Use a separate c:error element for each incoming document
  2. Add all incoming documents as children of a single c:error element.

To me the first makes more sense. It would allow you to raises multiple errors in one go. But it is not a very strong preference.

I would like to hear opinions and I think we should specify this.

@xatapult xatapult added the standard step library Issues for the standard step library label Sep 5, 2024
@ndw
Copy link
Collaborator

ndw commented Sep 5, 2024

I think it's a sequence so that it's optional, but one could pass multiple documents so we should specify what that means. I agree that separate c:error elements makes the most sense.

@ndw
Copy link
Collaborator

ndw commented Sep 5, 2024

Actually, on closer inspection, you can only provide one error code and that's on the c:error element, so maybe it makes more sense to say that multiple documents should be children of the c:error element.

On any other step, I'd be inclined to say that we should make it an error to provide more than one input, but on the p:error step, that just invites confusion I think: "error: your error was in error, it had more than one input"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
standard step library Issues for the standard step library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants