Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should options be inputs ? #20

Open
xquery opened this issue Feb 12, 2016 · 4 comments
Open

should options be inputs ? #20

xquery opened this issue Feb 12, 2016 · 4 comments

Comments

@xquery
Copy link

xquery commented Feb 12, 2016

we have discussed this before, but there are implications in terms of an API version, worth a re-discuss.

@htInEdin
Copy link
Collaborator

James Fuller writes:

we have discussed this before, but there are implications in terms of
an API version, worth a re-discuss.

I think so. Or rather, I think all options should be (understood as)
set from pipes, so that the dependency/ordering story is uniform.

ht

   Henry S. Thompson, School of Informatics, University of Edinburgh
  10 Crichton Street, Edinburgh EH8 9AB, SCOTLAND -- (44) 131 650-4440
            Fax: (44) 131 650-4587, e-mail: ht@inf.ed.ac.uk
                   URL: http://www.ltg.ed.ac.uk/~ht/

[mail from me always has a .sig like this -- mail without it is forged spam]

@xquery
Copy link
Author

xquery commented Feb 12, 2016

to simplify, would the signature of a step impl in another language be:

myLangFunc($options as map,Inputs ...)

or

we provide options as an input

myLangFunc(Inputs ...)

In previous discussions I sided with the former but I am concerned if we can get a stable signature across languages.

@ndw
Copy link
Collaborator

ndw commented Feb 12, 2016

I'd be reluctant to take on "stable signatures across languages" as a requirement. You wind up in IDL hell with APIs that suck in every language.

@xquery
Copy link
Author

xquery commented Feb 13, 2016

yes agreed, I am doing some research in how we might use annotations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants