Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cookie_cmp_wildcard_domain never matches #171

Open
greenrd opened this issue Jun 10, 2018 · 0 comments · May be fixed by #172
Open

cookie_cmp_wildcard_domain never matches #171

greenrd opened this issue Jun 10, 2018 · 0 comments · May be fixed by #172

Comments

@greenrd
Copy link

greenrd commented Jun 10, 2018

size_t is unsigned, so the loop test i >= 0 is always true.
greenrd added a commit to greenrd/httrack that referenced this issue Jun 10, 2018
@greenrd
Fix bug in cookie comparison
eab6b9a 
Fixes xroche#171
@greenrd greenrd linked a pull request Jun 10, 2018 that will close this issue
Open
mitchcapper pushed a commit to mitchcapper/httrack that referenced this issue Jul 27, 2022
@greenrd @mitchcapper
Fix bug in cookie comparison
ad797b6 
Fixes xroche#171
mitchcapper added a commit to mitchcapper/httrack that referenced this issue Jul 27, 2022
@mitchcapper @greenrd
Pr 172 (#2)
955523c 
* Fix bug in cookie comparison

Fixes xroche/xroche#171

* Add warning to detect this bug in future

* Fix other type-limits warnings

* Update copyright year

Co-authored-by: Robin Green <greenrd@greenrd.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug in cookie comparison greenrd/httrack
1 participant
@greenrd