This repository has been archived by the owner on Nov 14, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview for wizard-ui ready! Built with commit 8cb236a |
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
=======================================
Coverage 85.34% 85.34%
=======================================
Files 12 12
Lines 382 382
Branches 99 99
=======================================
Hits 326 326
Misses 55 55
Partials 1 1 Continue to review full report at Codecov.
|
wangkailang
suggested changes
Aug 12, 2019
wangkailang
reviewed
Aug 12, 2019
@@ -28,6 +28,7 @@ | |||
"rc-time-picker": "^3.7.1", | |||
"rc-tree": "^2.1.0", | |||
"react-bootstrap": "^0.31.1", | |||
"react-dev-utils": "^9.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
开发环境依赖,应该放在 dev 依赖中
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
生产 build 也用到了,这个用到了里面 hash 的规则,没有这个的话,hash 出来就是纯随机串,如果出现了问题不好进行定位
wangkailang
approved these changes
Aug 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
支持 css module,只有以 module.scss 结尾的文件才会启用