This repository has been archived by the owner on Nov 14, 2023. It is now read-only.
feat: VirtualSelectBox #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wangkailang
commented
Aug 28, 2019
•
wangkailang
commented
- 支持 VirtualSelectBox 组件
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
+ Coverage 78.07% 81.34% +3.26%
==========================================
Files 30 33 +3
Lines 967 1131 +164
Branches 201 234 +33
==========================================
+ Hits 755 920 +165
+ Misses 210 208 -2
- Partials 2 3 +1
Continue to review full report at Codecov.
|
|
Deploy preview for wizard-ui ready! Built with commit 6466fd2 |
lijianxin1202
suggested changes
Aug 29, 2019
| 'data-action'?: string; | ||
| } | string; | ||
| export type DropdownButtonMenuItem = | ||
| | { |
src/utils/elastic-query.ts
Outdated
| */ | ||
| function toStr(arr: ArrType[]) { | ||
| if (!(arr instanceof Array)) return ''; | ||
| const forward: any[] = []; |
There was a problem hiding this comment.
type ValueType = string | number;
type ArrType = {
type: string;
value: ValueType;
}
...
const forward: ValueType[] = [];| import React from 'react'; | ||
| import { mount } from 'enzyme'; | ||
| import VirtualSelectBox from './index'; | ||
| import getMockDatas from '../../../stories/utils/getMockDatas'; |
There was a problem hiding this comment.
这里在 components 里引用了 stories 里面的东西，stories 里面也需要引用 components 中的组件，所以类似 mock data 这种 components 和 stories 里面的都需要使用的方法是不是单独出来，让两个模块都引用这个更好些？
src/interface.tsx
Outdated
| query: Query; | ||
| } | ||
|
|
||
| export interface VirtualSelectBoxProps extends VirtualSelectBoxDefaultProps { |
There was a problem hiding this comment.
这里可以使用泛型来为约束 item 类型
export interface VirtualSelectBoxItem {
id?: number;
}
export interface VirtualSelectBoxProps<T> extends VirtualSelectBoxDefaultProps {
fetchData: (isReloading: boolean, query: Query, search?: string) => Promise<{
query: Query;
items: T[];
totalCount: number;
error?: string;
}>;
item?: T;
className?: string;
clear?: boolean;
onSelect?: (i: T) => void;
formatOption?: (item: T) => T;
}
export interface VirtualSelectBoxState<T> {
search: string;
items: T[];
query: Query;
isFetching: boolean;
totalCount: number;
isOpen: boolean;
isReloading: boolean;
error?: string;
}组件定义
class VirtualSelectBox<T extends VirtualSelectBoxItem> extends React.Component<VirtualSelectBoxProps<T>, VirtualSelectBoxState<T>> {}调用
type Data = { id?: number; name: string };
<VirtualSelectBox<Data>
item={{ id: 1, name: `${resName}-1` }}
fetchData={fetchDatas}
onSelect={noOp}
clear
/>为了解决 clear 时调用 onSelect({}) 报错，我们可以添加一个可选的默认值属性，类型也是 T，在 clear 时将默认值传入，也可以更方便的定制化
VirtualList 也可以这么修改
There was a problem hiding this comment.
666 呀，这种用法听实用的，也比较灵活，根据这个做个调整：
- 在
VirtualList上补充VirtualItem代替VirtualSelectBoxItem，并支持 string 类型； VirtualSelectBoxDefaultProps增加defaultItem指定为泛类型，解决onSelect({})的问题。
…al-select-box * 'master' of github.com:xsky-fe/wizard-ui: Release 0.2.0 feat: Add InputDropdown. (#64) # Conflicts: # src/interface.tsx
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.