This repository has been archived by the owner on Nov 14, 2023. It is now read-only.
fix: Panel add class name #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for wizard-ui ready! Built with commit 7a554f6 |
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
=======================================
Coverage 81.34% 81.34%
=======================================
Files 33 33
Lines 1131 1131
Branches 234 234
=======================================
Hits 920 920
Misses 208 208
Partials 3 3
Continue to review full report at Codecov.
|
wangkailang
suggested changes
Sep 3, 2019
src/components/Panel/index.tsx
Outdated
| <BootstrapPanel {...restProps} className={classNames(bgClass, textClass)}> | ||
| <BootstrapPanel | ||
| {...restProps} | ||
| className={classNames(bgClass, textClass, { className: true })} |
There was a problem hiding this comment.
className 是个常量？ 这样 class 变成了 xxx className
wangkailang
approved these changes
Sep 3, 2019
wangkailang
added a commit
that referenced
this pull request
Sep 4, 2019
…f github.com:xsky-fe/wizard-ui into refactor/compare-with-react-bootstrap * 'refactor/compare-with-react-bootstrap' of github.com:xsky-fe/wizard-ui: * 'master' of github.com:xsky-fe/wizard-ui: fix: Panel add class name (#70) # Conflicts: # src/components/Panel/index.tsx # src/interface.tsx
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.