This repository has been archived by the owner on Nov 14, 2023. It is now read-only.
feat: VirtualSelectBox multi select #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for wizard-ui ready! Built with commit caf5d61 |
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
==========================================
- Coverage 82.13% 80.51% -1.62%
==========================================
Files 37 38 +1
Lines 1304 1350 +46
Branches 261 273 +12
==========================================
+ Hits 1071 1087 +16
- Misses 230 260 +30
Partials 3 3
Continue to review full report at Codecov.
|
…at/VirtualSelectBox-multi-select * 'master' of https://github.com/xsky-fe/wizard-ui: Fix generics error in tsx. (#84) Feat/notification list (#73) refactor: Update docs code (#83) remove docs yarn.lock Refactor/action use yarn (#77) feat: Github actions (#76) # Conflicts: # docs/content/components/virtual-select-box.mdx # docs/gatsby-config.js # src/interface.tsx
lijianxin1202
suggested changes
Sep 20, 2019
| option = { | ||
| // @ts-ignore | ||
| label: item.name, | ||
| // @ts-ignore |
There was a problem hiding this comment.
如果不想验证 option 类型，可以在定义时显式声明为 any 类型：let option: any;
There was a problem hiding this comment.
这里是忽略 item（T 泛型）的类型定义
There was a problem hiding this comment.
之前 T 有默认类型定义倒是可以处理，现在没有默认的
lijianxin1202
approved these changes
Sep 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.