Loosen exp10 tests accuracy constraints

serge-sans-paille · serge-sans-paille · commit bcd7895003da · 2024-05-09T09:16:53.000+02:00
Both some scalar version and some vector version (depending on arch) are not totally accurate, so allow for some approximation. Should fix #917
diff --git a/test/test_xsimd_api.cpp b/test/test_xsimd_api.cpp
@@ -526,11 +526,9 @@ struct xsimd_api_float_types_functions
     void test_exp10()
     {
         value_type val(2);
-#ifdef EMSCRIPTEN
+        // exp10 doesn't always have an accurate implementation, so allow for
+        // approximate result
         CHECK_EQ(extract(xsimd::exp10(T(val))), doctest::Approx(std::pow(value_type(10), val)));
-#else
-        CHECK_EQ(extract(xsimd::exp10(T(val))), std::pow(value_type(10), val));
-#endif
     }
     void test_exp2()
     {

Original file line number	Diff line number	Diff line change
`@@ -526,11 +526,9 @@ struct xsimd_api_float_types_functions`
`526`	`526`	`void test_exp10()`
`527`	`527`	`{`
`528`	`528`	`value_type val(2);`
`529`		`-#ifdef EMSCRIPTEN`
	`529`	`+ // exp10 doesn't always have an accurate implementation, so allow for`
	`530`	`+ // approximate result`
`530`	`531`	`CHECK_EQ(extract(xsimd::exp10(T(val))), doctest::Approx(std::pow(value_type(10), val)));`
`531`		`-#else`
`532`		`- CHECK_EQ(extract(xsimd::exp10(T(val))), std::pow(value_type(10), val));`
`533`		`-#endif`
`534`	`532`	`}`
`535`	`533`	`void test_exp2()`
`536`	`534`	`{`