Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems in search & highlight #1680

Closed
jerch opened this issue Sep 10, 2018 · 3 comments
Closed

Problems in search & highlight #1680

jerch opened this issue Sep 10, 2018 · 3 comments
Labels
type/bug Something is misbehaving
Milestone

Comments

@jerch
Copy link
Member

jerch commented Sep 10, 2018

Entering this line with lots of spaces in the demo:

echo -e '                                          http://example.com      http://example.com'

pressing enter and searching for http shows two bugs:

  1. the first result gets highlighted in the line above - imho related to some trimming of white spaces from right (maybe the empty vs. space cell problem? see Buffer performance improvements #791 (comment))
  2. the second possible match in every line gets never highlighted

Problem one is new in master, problem two is also in 3.7. Have not tested older releases.

@jerch jerch added type/bug Something is misbehaving addon labels Sep 10, 2018
@Tyriar
Copy link
Member

Tyriar commented Sep 11, 2018

Problem 2 is captured in #1654

@Tyriar
Copy link
Member

Tyriar commented Sep 11, 2018

@jerch great find btw 😄

@Tyriar Tyriar added this to the 3.8.0 milestone Sep 11, 2018
@Tyriar
Copy link
Member

Tyriar commented Sep 11, 2018

@alexr00 can pick this one up 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something is misbehaving
Projects
None yet
Development

No branches or pull requests

2 participants