Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of fullwidth chars #1779

Closed
jerch opened this issue Nov 8, 2018 · 4 comments · Fixed by #2644
Closed

Better handling of fullwidth chars #1779

jerch opened this issue Nov 8, 2018 · 4 comments · Fixed by #2644
Assignees
Labels
Milestone

Comments

@jerch
Copy link
Member

jerch commented Nov 8, 2018

Currently non of the cell content insert/delete/replace methods handle previously added fullwidth chars at the position where the action takes place. All of those can break "fullwidth char cell pairs" by either cutting the left or the right part or even move the cells apart (insert).

Possible solution: Whenever a cell gets modified by any of the actions, we would have to check whether the cell is part of a fullwidth char and clear the other cell.

Affected by this:

  • InputHandler.eraseInLine
  • InputHandler.eraseInDisplay
  • InputHandler.deleteChars
  • InputHandler.insertChars
  • InputHandler.eraseChars
  • InputHandler.print (only after cursor jumps, normal input flow already handles this)

Might be easier to fix on buffer line level, since all above fall back to 3 methods - insertCells, deleteCells and replaceCells.

To avoid fixing this several times - blocked until we are settled with the buffer line implementation.

@jerch jerch added type/bug Something is misbehaving area/parser labels Nov 8, 2018
@jerch jerch self-assigned this Nov 8, 2018
@jerch jerch changed the title handling of fullwidth chars in insertChars/deleteChars better handling of fullwidth chars Nov 8, 2018
@skprabhanjan
Copy link
Contributor

@jerch , is this one good for me to work on ?

@jerch
Copy link
Member Author

jerch commented Nov 20, 2018

@skprabhanjan Dont think so as it is currently blocked until we are done with the buffer redesign. (see #791)

@skprabhanjan
Copy link
Contributor

@jerch, okay cool , thanks :)

@Tyriar Tyriar changed the title better handling of fullwidth chars Better handling of fullwidth chars Oct 7, 2019
@jerch
Copy link
Member Author

jerch commented Dec 6, 2019

We have a concrete issue with that in #2592. Trying to schedule this for next release.

@jerch jerch added this to the 4.4.0 milestone Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants