-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better handling of fullwidth chars #1779
Comments
jerch
changed the title
handling of fullwidth chars in insertChars/deleteChars
better handling of fullwidth chars
Nov 8, 2018
@jerch , is this one good for me to work on ? |
@skprabhanjan Dont think so as it is currently blocked until we are done with the buffer redesign. (see #791) |
@jerch, okay cool , thanks :) |
8 tasks
Tyriar
changed the title
better handling of fullwidth chars
Better handling of fullwidth chars
Oct 7, 2019
We have a concrete issue with that in #2592. Trying to schedule this for next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently non of the cell content insert/delete/replace methods handle previously added fullwidth chars at the position where the action takes place. All of those can break "fullwidth char cell pairs" by either cutting the left or the right part or even move the cells apart (insert).
Possible solution: Whenever a cell gets modified by any of the actions, we would have to check whether the cell is part of a fullwidth char and clear the other cell.
Affected by this:
InputHandler.eraseInLine
InputHandler.eraseInDisplay
InputHandler.deleteChars
InputHandler.insertChars
InputHandler.eraseChars
InputHandler.print
(only after cursor jumps, normal input flow already handles this)Might be easier to fix on buffer line level, since all above fall back to 3 methods -
insertCells
,deleteCells
andreplaceCells
.To avoid fixing this several times - blocked until we are settled with the buffer line implementation.
The text was updated successfully, but these errors were encountered: