Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

screenReaderMode should become a renderer addon #2095

Closed
Tyriar opened this issue May 19, 2019 · 1 comment
Closed

screenReaderMode should become a renderer addon #2095

Tyriar opened this issue May 19, 2019 · 1 comment
Labels
invalid

Comments

@Tyriar
Copy link
Member

Tyriar commented May 19, 2019

After #2005 is done it would make a lot of sense and clean up a bunch of code if we changed screenReaderMode to just be another renderer type.
@Tyriar Tyriar added type/debt Technical debt that could slow us down in the long run area/accessibility labels May 19, 2019
@Tyriar
Copy link
Member Author

Tyriar commented May 31, 2019

I changed my mind here. While they are very similar, it should work regardless of renderer. It would also duplicate a bunch of domrenderer code for no reason.

@Tyriar Tyriar closed this as completed May 31, 2019
@Tyriar Tyriar added invalid and removed area/accessibility type/debt Technical debt that could slow us down in the long run labels May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tyriar