Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Powershell resize #2798

Closed
trungutt opened this issue Mar 30, 2020 · 10 comments
Closed

Windows Powershell resize #2798

trungutt opened this issue Mar 30, 2020 · 10 comments

Comments

@trungutt
Copy link

trungutt commented Mar 30, 2020

I made an Electron app using xterm.js to integrate a terminal.

When the default terminal is Powershell, it doesn't resize correctly when maximizing/unmaximazing the windows. The same thing happened on Hyper, or Electerm which use xterm internally.

When using other things than Powershell, like cmd.exe, that works fine.

Details

  • Browser and browser version: Chrome
  • OS version: all Windows versions
  • xterm.js version: latest version

Steps to reproduce

  1. Default shell to Powershell
  2. Download and install Electerm on Windows (for example)
  3. type ls
  4. maximize the window (if it's not already maximized)
  5. unmaximize the window
  6. maximize the window
  7. type ls and see that ls is not positioned correctly

Screen capture here:

powershell resize

@Tyriar
Copy link
Member

Tyriar commented Apr 5, 2020

OS version: all Windows versions

What version of windows are you on? Type ver into cmd.

@mat007
Copy link

mat007 commented Apr 5, 2020

@Tyriar I’m on @trungutt’s team, I have the same issue, here is my Windows version

Microsoft Windows [Version 10.0.19592.1001]

I guess we’re all running Insider Rings versions on the team.

@Tyriar
Copy link
Member

Tyriar commented Apr 5, 2020

@mat007 does it happen when you try on Windows Terminal?

@Tyriar
Copy link
Member

Tyriar commented Apr 5, 2020

Also how are you creating the pty backend?

@Tyriar
Copy link
Member

Tyriar commented Apr 5, 2020

@mat007
Copy link

mat007 commented Apr 5, 2020

does it happen when you try on Windows Terminal?

As a matter of fact, it does! So I guess that means it’s a Powershell terminal bug…

@Tyriar
Copy link
Member

Tyriar commented Apr 5, 2020

@mat007 if it repros in windows terminal is means it's a conpty bug. You should report to https://github.com/microsoft/terminal

@Tyriar Tyriar closed this as completed Apr 5, 2020
@mat007
Copy link

mat007 commented Apr 5, 2020

Thanks @Tyriar 👍

@trungutt
Copy link
Author

trungutt commented Apr 6, 2020

A bit late but thanks @Tyriar

@trungutt
Copy link
Author

trungutt commented Apr 6, 2020

So I created another ticket on that microsoft/terminal#5254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants