Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make xterm.js trusted types compliant #3189

Closed
jrieken opened this issue Dec 2, 2020 · 0 comments · Fixed by #3190
Closed

Make xterm.js trusted types compliant #3189

jrieken opened this issue Dec 2, 2020 · 0 comments · Fixed by #3190
Milestone

Comments

@jrieken
Copy link
Contributor

jrieken commented Dec 2, 2020

We are making VS Code trusted types compliant (see microsoft/vscode#103699). This is to reduce potential XSS attacks and in essence about avoiding certain, dangerous DOM APIs, like assigning strings to innerHTML.

Searching for innerHTML makes me positive about this because not too many results show up. Low hanging/simple "fixes" are using innerText/textContent over innerHTML, see microsoft/vscode#106395 (comment) for more details

@Tyriar Tyriar added this to the 4.10.0 milestone Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants