Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a linting script #408

Closed
parisk opened this issue Dec 13, 2016 · 1 comment
Closed

Introduce a linting script #408

parisk opened this issue Dec 13, 2016 · 1 comment
Labels
type/proposal A proposal that needs some discussion before proceeding

Comments

@parisk
Copy link
Contributor

parisk commented Dec 13, 2016

I think that its a good idea to introduce a linting script and integrate it into our test procedure.

This will help us maintain a uniform code style in the repository.

I think that doing this just for ts files is the best option, since src/xterm.js still has LOTS of legacy code.

tslint looks like a good option.
@parisk parisk added the type/proposal A proposal that needs some discussion before proceeding label Dec 13, 2016
@Tyriar
Copy link
Member

Tyriar commented Dec 14, 2016

tslint works great in vscode 👍

@parisk parisk closed this as completed in 33f7d76 Dec 15, 2016
parisk referenced this issue Dec 15, 2016
@parisk
Merge pull request #411 from sourcelair/issue-#408-tslint
3a6368b 
Add tslint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/proposal A proposal that needs some discussion before proceeding
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@parisk @Tyriar