Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a stable line ID that continues to increment after being trimmed #5002

Open
Tyriar opened this issue Mar 15, 2024 · 0 comments
Open
Assignees
Labels
area/api type/enhancement Features or improvements to existing features

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 15, 2024

Some things we're looking at adding in VS Code are references to arbitrary ranges in the buffer like selection and command and would like some identifier that makes sense to both the UI and in the VS Code extension API. Here's a look at what file references look like to the user in Copilot:

image

I was thinking for terminal it would look similar, something like:

pwsh:123-103 PS C:....
(terminal title):(start line)-(end line) (preview of text)

We have markers but these are done in a way such that they don't track a stable line but instead continue to update. This refactor would also allow us to not update marker lines on every trim which would be a win for perf, especially when the embedder uses a lot of markers (like VS Code).

@Tyriar Tyriar added type/enhancement Features or improvements to existing features area/api labels Mar 15, 2024
@Tyriar Tyriar added this to the 5.5.0 milestone Mar 15, 2024
@Tyriar Tyriar self-assigned this Mar 15, 2024
@Tyriar Tyriar removed this from the 5.5.0 milestone Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api type/enhancement Features or improvements to existing features
Projects
None yet
Development

No branches or pull requests

1 participant