Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing npm package @xterm/addon-unicode-graphemes #5147

Open
PerBothner opened this issue Sep 4, 2024 · 3 comments
Open

missing npm package @xterm/addon-unicode-graphemes #5147

PerBothner opened this issue Sep 4, 2024 · 3 comments
Assignees
Labels
area/build Regarding the build process type/enhancement Features or improvements to existing features
Milestone

Comments

@PerBothner
Copy link
Contributor

There is no package for @xterm/addon-unicode-graphemes on npmjs.com.

Therefore, the Releases page has a bad link.

I have never uploaded anything to npmjs.com but I can certainly help with whatever files need to be created.

For a while, I've been focused on house construction, so there has been some bit-rot in both DomTerm and my forks of xterm.js. For example, configuring domterm using the --with-xtermjs=npm option is broken, and I'm trying to fix that.

@jerch
Copy link
Member

jerch commented Sep 4, 2024

Eww thats weird. I think this is the task which should have published it: https://github.com/xtermjs/xterm.js/actions/runs/8570982805/job/23490196733 Sadly the logs retention period is over, so not much to see there.

@Tyriar Could it be, that the first package upload to npm needs some sort of a manual step? I do not often create new packages there, so I am not sure about that.

Edit:

For a while, I've been focused on house construction, ...

Awesome, there is nothing better than building stuff, that will last for a while, with your own hands.

@Tyriar
Copy link
Member

Tyriar commented Sep 4, 2024

I think we just never turned it on when someone squatted the addon-unicode-graphemes package.

@Tyriar Tyriar added this to the 6.0.0 milestone Sep 4, 2024
@Tyriar Tyriar self-assigned this Sep 4, 2024
@Tyriar Tyriar added type/enhancement Features or improvements to existing features area/build Regarding the build process labels Sep 4, 2024
@PerBothner
Copy link
Contributor Author

PerBothner commented Sep 4, 2024

Probably unrelated:

$ npm install @xterm/xterm
npm ERR! code ETARGET
npm ERR! notarget No matching version found for xterm@^5.5.0.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.

npm ERR! A complete log of this run can be found in: /home/bothner/.npm/_logs/2024-09-04T20_02_43_244Z-debug-0.log

Updated: Fixed by editing package.json to ask for "@xterm/xterm" instead of "xterm".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Regarding the build process type/enhancement Features or improvements to existing features
Projects
None yet
Development

No branches or pull requests

3 participants