Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection goes crazy when you start dragging and then use mouse wheel #68

Closed
Tyriar opened this issue Jun 2, 2016 · 7 comments
Closed
Assignees
Labels
type/bug Something is misbehaving
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 2, 2016

Start:

image

Mouse wheel up:

image

@parisk parisk added the type/bug Something is misbehaving label Jun 2, 2016
@parisk
Copy link
Contributor

parisk commented Jun 2, 2016

Wild guess is that this is related to #67.

@Tyriar
Copy link
Member Author

Tyriar commented Jun 2, 2016

I think it's to do with the DOM being changed radically after a scroll, so the cursor ends up at the top-left (start) of the terminal.

@parisk
Copy link
Contributor

parisk commented Jun 3, 2016

This could be the case as well. Implementing natural scrolling, instead of virtual one, seems like could fix most of these issues.

@Tyriar
Copy link
Member Author

Tyriar commented Jun 3, 2016

That would probably lead to perf issues if the terminal buffer is too big, plus scrolling would not jump in character length blocks which would feel strange.

@parisk
Copy link
Contributor

parisk commented Jun 6, 2016

We could apply a limit to the terminal buffer size, which is something that even native apps do (e.g. Terminal.app).

@Tyriar
Copy link
Member Author

Tyriar commented Jun 6, 2016

I think it would be worth trying to get around the scrolling issues doing something like #69 before considering this route. That's a lot of DOM elements and imo the way it currently works is one of the great things about term.js; that it's footprint on the DOM is relatively small while maintaining a large buffer.

Plus it would probably need to recreate most lines on resize which could cause performance issues with a reasonably sized buffer limit.

@Tyriar
Copy link
Member Author

Tyriar commented Jun 9, 2017

Fixed in #670

@Tyriar Tyriar closed this as completed Jun 9, 2017
@Tyriar Tyriar added this to the 2.8.0 milestone Jun 9, 2017
@Tyriar Tyriar self-assigned this Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something is misbehaving
Projects
None yet
Development

No branches or pull requests

2 participants