-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selection goes crazy when you start dragging and then use mouse wheel #68
Comments
Wild guess is that this is related to #67. |
I think it's to do with the DOM being changed radically after a scroll, so the cursor ends up at the top-left (start) of the terminal. |
This could be the case as well. Implementing natural scrolling, instead of virtual one, seems like could fix most of these issues. |
That would probably lead to perf issues if the terminal buffer is too big, plus scrolling would not jump in character length blocks which would feel strange. |
We could apply a limit to the terminal buffer size, which is something that even native apps do (e.g. Terminal.app). |
I think it would be worth trying to get around the scrolling issues doing something like #69 before considering this route. That's a lot of DOM elements and imo the way it currently works is one of the great things about term.js; that it's footprint on the DOM is relatively small while maintaining a large buffer. Plus it would probably need to recreate most lines on resize which could cause performance issues with a reasonably sized buffer limit. |
Fixed in #670 |
Start:
Mouse wheel up:
The text was updated successfully, but these errors were encountered: