Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal is initialised with the wrong cursor style #790

Closed
mofux opened this issue Jul 12, 2017 · 2 comments · Fixed by #781
Closed

Terminal is initialised with the wrong cursor style #790

mofux opened this issue Jul 12, 2017 · 2 comments · Fixed by #781
Assignees
@mofux
Labels
type/bug Something is misbehaving
Milestone
2.9.0

Comments

@mofux
Copy link
Contributor

mofux commented Jul 12, 2017

When creating the terminal, and passing the cursorStyle through options, the cursor will still be block. One has to trigger setOption before the cursor style is picked up. This is because the class for the cursor style xterm-cursor-style-... is not set when creating the terminal.
@mofux mofux mentioned this issue Jul 12, 2017
Merged
@Tyriar Tyriar added the type/bug Something is misbehaving label Jul 12, 2017
@Tyriar
Copy link
Member

Tyriar commented Jul 12, 2017

Nice find, repro'd in the demo. I missed this because we apply all options after the terminal is initialized.

@mofux
Copy link
Contributor Author

mofux commented Jul 12, 2017

I was able to fix this in #781 via 98d9b5e

@Tyriar Tyriar added this to the 2.9.0 milestone Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mofux mofux

Labels
type/bug Something is misbehaving
Projects
None yet
Milestone
2.9.0
Development

Successfully merging a pull request may close this issue.

Retain the color of a character for underline and bar cursor styles
2 participants
@Tyriar @mofux