-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy load BellSound using TS dynamic imports #894
Comments
If lazy import is not an option, couldn't we load it similar to the way we load addons currently? |
The addon loading logic is so messy imo, hopefully we can get away without doing something like that. |
Yeah... I think the problem is that there are all these different loaders we have to support. Would be nice to have an abstraction for those, so we could simply import resources lazily. Mmmmpf... that's the part of modern javascript that really sucks - I hope this problem will be solved once the official html module api has settled. Anyway, I don't really see a way of loading the bell audio lazily without it. Even if we get the dynamic imports to work it will depend on the loader (e.g. webpack) to support it. |
Using dynamic imports in a library is a bit of a mess, I don't think we should do this. The current situation is decent. |
After #878 BellSound will be loaded in before the Terminal is initialized, delaying the time it takes and increasing the memory even when no bell is desired.
See microsoft/TypeScript#12364
The text was updated successfully, but these errors were encountered: