Reactivate block test in wasm-parser

[xtuc]

Here's the test:

webassemblyjs/packages/wasm-parser/test/fixtures/block/with-label/actual.wat-failure

Line 3 in fed1520

(block $test)

It has been disabled in #276

[ColinEberhardt]

Hmm ... can blocks have names? I can't find the reference right now, but I have a feeling that this was a feature that was removed before v1 of WebAssembly. Instructions like br, br_if, ... all break to a specific depth rather than a label.

Also, running wat2wasm --debug-names with the following:

(module
  (func
    (block $test)
  )
)

Does not include the string 'test' in the custom name section.

[ColinEberhardt]

Although a label is mentioned in the spec:

[ColinEberhardt]

Despite the spec indicating that branch instructions can use labels or indices, I can't find any examples in the test suite (https://github.com/WebAssembly/testsuite) that use labels.

[xtuc]

Ok, thanks for the clarification.

The name is probably available in WAST as syntactic sugar but not actual semantics.

So I guess we should just remove this test?

[ColinEberhardt]

Yes, I agree, this should be removed.