Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binary string regex #1415

Merged
merged 4 commits into from
Dec 6, 2022
Merged

Fix binary string regex #1415

merged 4 commits into from
Dec 6, 2022

Conversation

nesstord
Copy link
Contributor

@nesstord nesstord commented Dec 6, 2022

PR Details

Change regex value for "bstrUnmarshal" function in "lib.go" file.

Description

The value of the regex "x[a-zA-Z\d]{4}" has been changed to "x[a-fA-F\d]{4}" because hexadecimal values only contain the characters A-F.

Related Issue

#1414

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@xuri xuri added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 6, 2022
@xuri xuri linked an issue Dec 6, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2022

Codecov Report

Merging #1415 (029af0f) into master (5e0953d) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1415      +/-   ##
==========================================
- Coverage   98.53%   98.50%   -0.04%     
==========================================
  Files          31       31              
  Lines       23947    23947              
==========================================
- Hits        23596    23588       -8     
- Misses        232      239       +7     
- Partials      119      120       +1     
Flag Coverage Δ
unittests 98.50% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib.go 96.78% <ø> (-1.52%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@xuri xuri added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 6, 2022
Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I have update test case and made some changes for this based on your branch, and this feature will be released in the next version.

@xuri xuri merged commit 61fda0b into qax-os:master Dec 6, 2022
xuri pushed a commit to JDavidVR/excelize that referenced this pull request Jul 11, 2023
jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while parsing the binary basic string
3 participants