-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix binary string regex #1415
Fix binary string regex #1415
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1415 +/- ##
==========================================
- Coverage 98.53% 98.50% -0.04%
==========================================
Files 31 31
Lines 23947 23947
==========================================
- Hits 23596 23588 -8
- Misses 232 239 +7
- Partials 119 120 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. I have update test case and made some changes for this based on your branch, and this feature will be released in the next version.
PR Details
Change regex value for "bstrUnmarshal" function in "lib.go" file.
Description
The value of the regex "x[a-zA-Z\d]{4}" has been changed to "x[a-fA-F\d]{4}" because hexadecimal values only contain the characters A-F.
Related Issue
#1414
Types of changes