This repository has been archived by the owner on Oct 10, 2018. It is now read-only.
Add sort=ascending to amp-live-list for comments when asc order #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
kienstra
approved these changes
Apr 2, 2018
There was a problem hiding this comment.
Approved, Minor Point
Hi @westonruter,
This looks good. There's a minor point, but it's not a blocker to merging.
If it's alright, I'm going to merge this now.
| @@ -29,7 +29,8 @@ | |||
|
|
|||
| <div class="comments wrap__item"> | |||
|
|
|||
| <amp-live-list id="amp-live-comments-list-<?php the_ID(); ?>" class="live-list" layout="container" data-poll-interval="<?php echo esc_attr( AMPCONF_LIVE_LIST_POLL_INTERVAL ); ?>" data-max-items-per-page="<?php echo esc_attr( get_option( 'page_comments' ) ? get_option( 'comments_per_page' ) : 10000 ); ?>"> | |||
| <?php $sort_attr = ( 'asc' === get_option( 'comment_order' ) ) ? ' sort="ascending" ' : ''; ?> | |||
There was a problem hiding this comment.
Maybe this could be 'sort="ascending"' instead of ' sort="ascending" '. When this is echoed on the next line, there are already empty spaces before and after.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ampproject/amp-wp#1024