Record timestamp creation refactored #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasparsd
approved these changes
Jul 28, 2020
| @@ -138,7 +135,7 @@ function ( $var ) { | |||
| 'blog_id' => (int) apply_filters( 'wp_stream_blog_id_logged', get_current_blog_id() ), | |||
| 'user_id' => (int) $user_id, | |||
| 'user_role' => (string) $role, | |||
| 'created' => (string) $iso_8601_extended_date, | |||
| 'created' => (string) current_time( 'mysql', true ), | |||
There was a problem hiding this comment.
We always need the UTC timestamp formatted for the DATETIME field in the DB so this will ensure we always get that consistent value.
This is different from the current behaviour of wp_stream_get_iso_8601_extended_date() which always adds the timezone information:
Line 62 in 4f85afb
which was probably causing the bug as the MySQL client wasn't able to cast it to a valid DATETIME value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1140
Summary
This replaces the usage of
wp_stream_get_iso_8601_extended_date()for creating record timestamp withcurrent_time()