Make meta fields saved by log() method translation-independent

[powelski]

Currently, WP_Stream::log() method uses passed parameters (saved as meta) as translation tokens. This shouldn't work like that, because sometimes there's a need to do translations this way: "%1$s" setting was updated in the %2$sCustomizer%3$s

Where 2nd and 3rd tokens are anchor tag, respectively opening and closing. For English language exclusively, this way would be enough: "%1$s" setting was updated in the %2$s

Where second token would be translated Customizer text. For some languages (like Polish) this is not enough, because Customizer word is different depending on the context and that would be really confusing to have it separately. Saving those as meta is not wanted.

[powelski]

I think this is a good place to discuss our policy about anchors in logs messages. I think messages are not the best place to keep links, instead it's better to have action links under it.

But even though, I think there could be additional parameter in log() method to keep translation tokens in regular, ordered array. Current way doesn't seem to be very stable and logical.

[shadyvb]

@powelski Can you propose the code change you have in mind via a PR so we can discuss it there ?

[lukecarbis]

I think #380 would resolve this issue.

[shadyvb]

@lukecarbis I'm not sure if it is related, this here is discussing meta values and links within summaries, which i believe doesn't happen with any of the current connectors.

[frankiejarrett]

Closing this until there is a proposed solution.