Installer connector test implemented #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidunot89
added
needs discussion
kasparsd
reviewed
Aug 14, 2020
docker-compose.yml
Outdated
| @@ -6,7 +6,7 @@ services: | |||
| image: mysql:5 | |||
| volumes: | |||
| - db_data:/var/lib/mysql | |||
| restart: always | |||
| restart: unless-stopped | |||
There was a problem hiding this comment.
This appears to not start the container if it has been stopped manually. Are we sure this is not going to cause unexpected results during test runs, for example?
There was a problem hiding this comment.
I'll remove it, just wanted an alternative to always for local development, to prevent the container from being rebuilt on boot.
kidunot89
force-pushed
the
tests/installer-connector
branch
from
6d04dbe
to
c16096c
Compare
kidunot89
changed the title
kidunot89
removed
needs discussion
kidunot89
force-pushed
the
tests/installer-connector
branch
from
2a8ed42
to
4c1aa88
Compare
kidunot89
force-pushed
the
tests/installer-connector
branch
from
4c1aa88
to
dfca985
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #1093
Summary Checklist
upgrader_process_completecallback test implemented and passing.activate_plugincallback test implemented and passing.deactivate_plugincallback test implemented and passing.delete_site_transient_update_themescallback test implemented and passing.pre_set_site_transient_update_pluginscallback test implemented and passing._core_updated_successfullycallback test implemented and passing.switch_themecallback test implemented and passing.Some tests are incomplete and skipped because I can't find a way to simulate the scenarios needed.