Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show minification request date/time in admin page #43

Closed
shadyvb opened this issue Oct 30, 2013 · 4 comments
Closed

Show minification request date/time in admin page #43

shadyvb opened this issue Oct 30, 2013 · 4 comments
Assignees

Comments

@shadyvb
Copy link
Contributor

shadyvb commented Oct 30, 2013

Sometimes the request is not carried out successfully, be it for a faulty URL, or a security barrier or anything else.

We need to show date/time of requests, and accordingly warn the user of such delays, and probably give him a way to instantly generate those minifed groups ?

@westonruter
Copy link
Contributor

Good idea. Yeah, there could be a button to force-trigger the action that normally would be triggered by wp-cron.

How would we report if a request was carried out successfully or not? How could we detect for such errors if cron can't be pinged in the first place.

@shadyvb
Copy link
Contributor Author

shadyvb commented Oct 30, 2013

@westonruter Reporting a job that has a request time of X while X >= cron interval or something.

And on the force-trigger call we can make a non-async AJAX so we get the result instantly.

@westonruter
Copy link
Contributor

I don't think we have to go the route of doing a synchronous XHR. As long as the request is done in-page and not in background via cron, I think we're good.

@shadyvb
Copy link
Contributor Author

shadyvb commented Oct 30, 2013

That's actually what i meant, i didn't mean asyc: false ( although it pretty much seems so! ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants