Selection fails to highlight

[hackedXD]

gotop version - gotop v4.1.4.r0.gcd0cf0f
os - Arch Linux 5.18.11-zen1-1-zen
Alacritty on Wayland

5.18.11-zen1-1-zen

[fanitriastowo]

Same here. It was fine before I upgrade to v4.1.4

gotop version: gotop v4.1.4 (Hadean)
os: manjaro kernel 5.15.54-1
terminal: konsole
display: X11

[bbjubjub2494]

Same here. I bisected it to these 4 commits cd44aab, 3c148a4, c3aeb75 and 387c463. It looks like it comes from termui or another dependency.

Version: gotop v4.1.4 (Hadean) (via Nixpkgs)
OS: Linux 5.15.55, NixOS, 22.05 (Quokka), 22.05.20220718.3eb3df0
Terminal Emulator: ate
Display: X11 (dwm, picom)

EDIT: I also tried another TE (kitty), it's visible but it still looks different than v4.1.3.

[JC-Morph]

same issue
OS: Artix Linux x86_64
Kernel: 5.18.12-artix1-1
Terminal: st

[mclang]

Arch, and i3 here... None of the color schemes work with Alacritty, Tilix or XFCE term.

[cmalvi]

same with gnome terminal

[bbjubjub2494]

Still an issue in 4.2.0 (similar environment)

[ChausseBenjamin]

Same with ST here (on4.2.0):

[gardockt]

Oddly enough, this patch makes the selection work again for me:

diff --git a/termui/table.go b/termui/table.go
index 29e4c3f..e914a5d 100644
--- a/termui/table.go
+++ b/termui/table.go
@@ -98,7 +98,7 @@ func (self *Table) Draw(buf *Buffer) {
                if self.ShowCursor {
                        if (self.SelectedItem == "" && rowNum == self.SelectedRow) || (self.SelectedItem != "" && self.SelectedItem == row[self.UniqueCol]) {
                                style.Fg = self.CursorColor
-                               style.Modifier = ModifierReverse
+                               style.Modifier = 1 << 15
                                for _, width := range self.ColWidths {
                                        if width == 0 {
                                                continue

This issue seems to begin with commit c3aeb75, as a result of termbox-go dependency bump - reverting it resolves the issue. I couldn't, however, manage to replicate the issue with a simple program, as reverse modifier in this code works fine:

package main

import (
	"image"
	"log"

	ui "github.com/gizak/termui/v3"
)

type Table struct {
	*ui.Block
}

func NewTable() *Table {
	return &Table{
		Block:       ui.NewBlock(),
	}
}

func (self *Table) Draw(buf *ui.Buffer) {
	self.Block.Draw(buf)

	style := ui.NewStyle(4)
	style.Modifier = ui.ModifierReverse
	buf.SetString(
		"hello",
		style,
		image.Pt(self.Inner.Min.X, self.Inner.Min.Y),
	)
}

func main() {
	if err := ui.Init(); err != nil {
		log.Fatalf("failed to initialize termui: %v", err)
	}
	defer ui.Close()

	p := NewTable()
	p.SetRect(0, 0, 50, 25)

	ui.Render(p)

	for e := range ui.PollEvents() {
		if e.Type == ui.KeyboardEvent {
			break
		}
	}
}

[Geometer1729]

@gardockt's fix works for me too

[DaL31]

Arch and i3 here. Problem still persists even though I have the newest version with the pr. Any ideas?

[xxxserxxx]

Yeah, I got a regression on my side too. I'm just commenting that I'm aware of the issue and am neither dead, nor ignoring it; I simply haven't had time to context switch back to gotop in a while.

[LouDnl]

Same issue here on different systems with the latest version.