Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Should we adopt ASP.NET Core types? #200

Open
panesofglass opened this issue Mar 8, 2018 · 5 comments
Open

Should we adopt ASP.NET Core types? #200

panesofglass opened this issue Mar 8, 2018 · 5 comments

Comments

@panesofglass
Copy link
Contributor

Should we drop OWIN in favor of the ASP.NET types so that we could potentially improve performance and pick up more interop possibilities? I don’t have any specific things in mind and would love to know what others think.

@panesofglass
Copy link
Contributor Author

Ping @kolektiv @neoeinstein

@panesofglass
Copy link
Contributor Author

@et1975 noted that he uses Freya on Nowin, so that would likely prohibit moving off OWIN, at least for his case. I still think this worth further discussion, specifically for reasons of performance. I think the Freya abstractions make it such that the lower level types can remain completely hidden, meaning there's a possibility of having a switch to use one set of types versus another, though that could get quite messy to maintain.

@et1975
Copy link

et1975 commented Oct 11, 2018

To be fair, that was a while ago - at the time that was the fastest combo, but all projects since were Kestrel-hosted. If I was to touch that project again I'd move it to Kestrel, so please consider it as "building on OWIN was a good architectural decision" sort of comment.

@btrepp
Copy link

btrepp commented Oct 16, 2018

Currently I'm using freya -> Owin -> Http.sys to host my applications, I have been considering seeing if i can use a similar method to use Suave as the web server.

I haven't looked into ASP.NET in a year. What does moving to ASP.NET types give us in terms of support, for other hosts?. Would these types be compatible with hosting freya on suave?

@panesofglass
Copy link
Contributor Author

@btrepp I think it would require a Suave adapter. OWIN is certainly a better option as it's already supported in most (or all) hosting options. The benefit of switching to the ASP.NET Core types is that it removes this mapping layer. It's not explicit, as ASP.NET Core provides a built-in adapter, however, this requires allocations that would be better avoided. It's certainly possible that we could potentially consider removing OWIN in favor of a number of Core + Optics implementations built to each host.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants