Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font-Size: 1.03rem #12

Open
caillou opened this issue May 18, 2020 · 4 comments
Open

Font-Size: 1.03rem #12

caillou opened this issue May 18, 2020 · 4 comments

Comments

@caillou
Copy link
Contributor

caillou commented May 18, 2020

The body has a confusing font-size of 1.03rem.

Given that most browsers have a base font-size of 16px, we end up with a font-size of 16.43px. This seems like an odd choice, especially on normal-density screens.

What is the rational behind this value?
If this has a reason, could you add a comment?
@halfmage
Copy link

I thought about the same. This affects not only the body text to have 16.43px but also all other elements that have rem values for there size, padding, and margin. Fixed it in PR #25

@caillou
Copy link
Contributor Author

caillou commented May 20, 2020 •
edited
Loading

Actually it does not affect the rem as the font-size is set on the <body> element. AFIK the rem unit is based on the font-size defined on the the root html element.

rem values were invented in order to sidestep the compounding problem. rem values are relative to the root html element, not the parent element.

– mdn/font-size

@halfmage
Copy link

Yes you are right. My point was caused by stuff like .9rem in one case. But anyway I would prefer 1rem for body text size.

@3x
Copy link
Member

3x commented May 22, 2020

Will take a look at these. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@caillou @halfmage @3x