Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pathExists and isDirectory performance once graceful-fs supports it #109

Closed
markjm opened this issue Nov 8, 2021 · 1 comment
Closed
Assignees

Comments

@markjm
Copy link
Contributor

markjm commented Nov 8, 2021

Once this change is merged: isaacs/node-graceful-fs#221, stop throwing errors in below places:

this.fs.statSync(filename);

isDir = this.fs.statSync(dir).isDirectory();

Since we expect this can be null, we skip a lot of overhead in creating these errors. Skipping these errors is over a 3x speedup for these calls
nodejs/node#33716

@xz64
Copy link
Owner

xz64 commented Jan 22, 2022

Implemented by @markjm in #114

@xz64 xz64 closed this as completed Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants