Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateTimeUtils is insufficiently tested #298

Closed
cdeszaq opened this issue May 24, 2017 · 3 comments
Closed

DateTimeUtils is insufficiently tested #298

cdeszaq opened this issue May 24, 2017 · 3 comments
Assignees
@QubitPi
Labels
DATE TIME TECH-DEBT TESTING WIP

Comments

@cdeszaq
Copy link
Collaborator

cdeszaq commented May 24, 2017

Some of the methods are unused and could be removed. Perhaps instead this could be pulled into it's own module?
@QubitPi QubitPi self-assigned this Nov 29, 2017
@QubitPi QubitPi added the WIP label Nov 29, 2017
@QubitPi
Copy link
Contributor

QubitPi commented Nov 29, 2017

I'm working on it.

@QubitPi QubitPi mentioned this issue Dec 3, 2017
Merged
@QubitPi
Copy link
Contributor

QubitPi commented Dec 3, 2017

I've added tests for all methods, because down-stream projects might use all of them.

@QubitPi
Copy link
Contributor

QubitPi commented Dec 10, 2017

Addressed by #595

@QubitPi QubitPi closed this as completed Dec 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QubitPi QubitPi

Labels
DATE TIME TECH-DEBT TESTING WIP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdeszaq @QubitPi