Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter variables and methods in DataApiRequest are confusing #497

Closed
tarrantzhang opened this issue Aug 10, 2017 · 2 comments
Closed

Filter variables and methods in DataApiRequest are confusing #497

tarrantzhang opened this issue Aug 10, 2017 · 2 comments
Labels
LOW HANGING TECH-DEBT

Comments

@tarrantzhang
Copy link
Collaborator

ApiFilter is call filters while Druid filter is call filter in DataApiRequest. This is very confusing for people trying to understand the code. In my opinion, they should be changed to apiFilter and druidFilter respectively. And also their getters.
@mpardesh mpardesh mentioned this issue Aug 16, 2017
Merged
@michael-mclawhorn
Copy link
Contributor

There's a reason that API filters are considered plural while Druid filters are singular. Because API filters are treated as a list (or a list grouped into a map by dimension) while the Druid filters are a tree with a leaf node as the reference variable.

@QubitPi
Copy link
Contributor

QubitPi commented Nov 21, 2017

Addressed by #507

@QubitPi QubitPi closed this as completed Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
LOW HANGING TECH-DEBT
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@michael-mclawhorn @kevinhinterlong @tarrantzhang @QubitPi