Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making Custom Sketch operations possible in PostAggreations #740

Closed
deepakb91 opened this issue Jul 12, 2018 · 1 comment
Closed

Making Custom Sketch operations possible in PostAggreations #740

deepakb91 opened this issue Jul 12, 2018 · 1 comment

Comments

@deepakb91
Copy link
Collaborator

  1. The asSketchEstimate(SketchAggregation candidate) of ThetaSketchFieldConverter class currently takes SketchAggregation as the parameter and returns SketchAggregation as a ThetaSketchEstimatePostAggregation .
  2. Rather than taking SketchAggregation as a parameter, we can make two versions of asSketchEstimate with one taking Aggregation as a parameter and the other taking PostAggregation as a parameter so that only the metrics which are part of Aggregation are marked as field access whereas the ones which are part of PostAggregation are not.
  3. This will help in doing some custom sketch operations in the PostAggregations.
@deepakb91 deepakb91 mentioned this issue Jul 12, 2018
Merged
@QubitPi
Copy link
Contributor

QubitPi commented Jul 19, 2018

Resolved by #741

@QubitPi QubitPi closed this as completed Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@QubitPi @deepakb91