fix: FormattedRelativeTime with high seconds values (#1385)

* Fix FormattedRelativeTime with high seconds values

Expected:
For an item with an age of 3 days, on initial load don't add the timer but do show "3 days ago"

Actual:
Item shows "1 day ago" now matter how old it is

The FormattedRelativeTime intends to stop using a timer once it goes over one day. However, at the point it removes this timer it also fixes the value at one day, so the display can only ever be "1 day ago", which is incorrect.

This fix removes the overriding of the current state value, but continues to bypass the timer. It also adds a test for this case (which was failing before the fix)

Author: djmarland

src/components/relative.tsx

@@ -116,9 +116,7 @@ class FormattedRelativeTime extends React.PureComponent<Props, State> {
     const nextUnit = selectUnit(nextValueInSeconds);
     // We've reached the max auto incrementable unit, don't schedule another update
     if (nextUnit === 'day') {
-      return this.setState({
-        currentValueInSeconds: nextValueInSeconds < 0 ? -DAY : DAY,
-      });
+      return;
     }
 
     const unitDuration = getDurationInSeconds(nextUnit);

test/unit/components/relative.tsx

@@ -194,6 +194,17 @@ describe('<FormattedRelative>', () => {
       (rendered.find(BaseFormattedRelativeTime).instance() as any)._updateTimer
     ).toBeNull();
   });
+  it('should show high seconds values as days with no timer', function() {
+    // span bc enzyme support for </> seems buggy
+    const rendered = mountWithProvider(
+      {value: -(60 * 60 * 24 * 3), unit: 'second', updateIntervalInSeconds: 1},
+      {...intl, textComponent: 'span'}
+    ).find(BaseFormattedRelativeTime);
+    expect(rendered.text()).toBe(intl.formatRelativeTime(-3, 'day'));
+    expect(
+      (rendered.find(BaseFormattedRelativeTime).instance() as any)._updateTimer
+    ).toBeNull();
+  });
   it('should throw if try to increment in day', function() {
     // span bc enzyme support for </> seems buggy
     expect(() =>